fixed updateTorDB.sh #558
Merged
fixed updateTorDB.sh #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwards counting was broken, now fixed, it just missed a -1 from $(seq $n 0) to $(seq $n -1 0)
phaag
reviewed
Aug 22, 2024
|
I initially thought the same, but after testing it on newer and very old linux distributions — where they all exhibited the same behavior without -1 it didn’t work. tested distros: |
phaag
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The script was only able to download data for one month using ./updateTorDB.sh 1. Any attempt to specify a higher value failed because the backward counting mechanism was broken. The issue was due to a missing
-1in the sequence loop. It needed to be changed from:$(seq $n 0)to
$(seq $n -1 0)BR
Takalele