Fix ./configure --disable-xxxx handling. #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional note: I was unable to test with |
Corrected use of $enabled_xxxx vs $build_xxxx where appropriete.
phaag
approved these changes
Oct 18, 2023
|
Thanks! |
|
I also pushed another commit [to the same branch] to attempt to fix the remaining issues, if you're interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configure script assumes
AC_ARG_ENABLEset is only triggered with--enable-xxxx. This breaks when--disable-xxxxis used. Removing handling fromAC_ARG_ENABLEand checking$enable_xxxxdirectly fixes this issue.There are some other cases where
AC_ARG_ENABLEis setting a custom variable. These were left unchanged and may have the same issue if using hard-codedyesvalues instead of$enableval.