Skip to content

Commit

Permalink
[CLOUD-131037] enable to specify aux osx runner tags (Cloud-Foundatio…
Browse files Browse the repository at this point in the history
…ns#13)

Co-authored-by: Dušan Klinec <[email protected]>
  • Loading branch information
Dusan Klinec and ph4r05 committed May 24, 2024
1 parent 937437e commit 34358d9
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 8 deletions.
1 change: 1 addition & 0 deletions .github/workflows/_build-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
uses: ./.github/workflows/_build-osx.yml
with:
official: ${{ inputs.official }}
runs-on: ${{ vars.OSX_RUNS_ON }}
secrets:
APPLE_DEV_P12_BASE64: ${{ secrets.APPLE_DEV_P12_BASE64 }}
APPLE_INS_P12_BASE64: ${{ secrets.APPLE_INS_P12_BASE64 }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_build-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
type: boolean

jobs:
build:
build-linux:
runs-on: [self-hosted, pure1build]
container:
image: artifactory.pstg-inf.net:443/dockerhub-registry-1/golang:1.21-bullseye
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/_build-osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
official:
required: true
type: boolean
runs-on:
description: 'Extra runner tags'
type: string
required: false
secrets:
APPLE_DEV_P12_BASE64:
required: true
Expand All @@ -19,8 +23,8 @@ on:
required: true

jobs:
build:
runs-on: [self-hosted, macOS, p1sp]
build-osx:
runs-on: ${{ fromJson(format('["self-hosted","macOS", {0}]', inputs.runs-on)) }}
permissions:
contents: read
actions: read
Expand Down Expand Up @@ -80,10 +84,10 @@ jobs:
name: keymaster.pkg
path: keymaster.pkg

sign:
sign-osx:
runs-on: [ self-hosted, macOS, p1sp ]
needs:
- build
- build-osx
environment: production
if: inputs.official # Only sign on the main branch
permissions:
Expand Down Expand Up @@ -147,7 +151,7 @@ jobs:
pkgbuild \
--root package \
--identifier "${{ vars.APPLE_BUNDLE_ID }}" \
--version "${{ needs.build.outputs.version }}" \
--version "${{ needs.build-osx.outputs.version }}" \
--install-location /usr/local/bin \
keymaster-unsigned.pkg
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
type: boolean

jobs:
build:
build-windows:
runs-on: [self-hosted, Windows]
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ endif
BINARY=keymaster

# These are the values we want to pass for Version and BuildTime
VERSION?=1.15.10
VERSION?=1.15.11
DEFAULT_HOST?=
VERSION_FLAVOUR?=
EXTRA_LDFLAGS?=
Expand Down
1 change: 1 addition & 0 deletions PureStorage.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ APPLE_INS_IDENTITY: Developer ID Installer: Pure Storage Inc. (4PQYP85VSU)
APPLE_ID_INTERMEDIATE_CERT_URL: https://www.apple.com/certificateauthority/DeveloperIDG2CA.cer
APPLE_TEAM_ID: 4PQYP85VSU
APPLE_ID: [email protected]
OSX_RUNS_ON: p1sp
```

#### Secrets
Expand Down

0 comments on commit 34358d9

Please sign in to comment.