[ESP32] Remove dead code and __func__ from error logging (project-chi…

…p#32431)
pgregorr-amazon · Mar 5, 2024 · b029237 · b029237
1 parent 7af8313
commit b029237
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/src/platform/ESP32/ConfigurationManagerImpl.cpp b/src/platform/ESP32/ConfigurationManagerImpl.cpp
@@ -44,15 +44,6 @@ namespace DeviceLayer {
 
 using namespace ::chip::DeviceLayer::Internal;
 
-namespace {
-
-enum
-{
-    kChipProduct_Connect = 0x0016
-};
-
-} // unnamed namespace
-
 // TODO: Define a Singleton instance of CHIP Group Key Store here (#1266)
 
 ConfigurationManagerImpl & ConfigurationManagerImpl::GetDefaultInstance()

diff --git a/src/platform/ESP32/nimble/BLEManagerImpl.cpp b/src/platform/ESP32/nimble/BLEManagerImpl.cpp
@@ -1462,7 +1462,7 @@ void BLEManagerImpl::HandleC3CharRead(struct ble_gatt_char_context * param)
 exit:
     if (err != CHIP_NO_ERROR)
     {
-        ChipLogError(DeviceLayer, "Failed to generate TLV encoded Additional Data (%s)", __func__);
+        ChipLogError(DeviceLayer, "Failed to generate TLV encoded Additional Data, err:%" CHIP_ERROR_FORMAT, err.Format());
     }
     return;
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     exit:
         if (err != CHIP_NO_ERROR)
         {
-            ChipLogError(DeviceLayer, "Failed to generate TLV encoded Additional Data (%s)", __func__);
+            ChipLogError(DeviceLayer, "Failed to generate TLV encoded Additional Data, err:%" CHIP_ERROR_FORMAT, err.Format());
         }
         return;
     }
@@ Expand Down @@