Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add export_testcase to support length 1 arrays and lists #822

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add export_testcase to support length 1 arrays and lists #822

wants to merge 2 commits into from

Conversation

impactaky
Copy link
Contributor

Problem

The output allows a tuple or list of length 1, but not input.

Reproduction

checkout 8defb94 and run

pytest tests/pytorch_pfn_extras_tests/onnx_tests/test_export_testcase.py -k test_export_tuple_input

This PR

Add processing equivalent to output to input.

@kmaehashi kmaehashi added the cat:enhancement New feature or request label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuzijian629 xuzijian629 Awaiting requested review from xuzijian629

@asi1024 asi1024 Awaiting requested review from asi1024 asi1024 is a code owner

@kmaehashi kmaehashi Awaiting requested review from kmaehashi kmaehashi is a code owner

@linshokaku linshokaku Awaiting requested review from linshokaku linshokaku is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@linshokaku linshokaku

Labels
cat:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impactaky @kmaehashi @linshokaku