Skip to content

Commit

Permalink
Remove Allows header check
Browse files Browse the repository at this point in the history
It is not clear that we should be checking for the ALLOW header when testing. This was discussed in [27](#27). Allow is part of CORS and we are likely using it wrongly. The proposed way of dealing with this is to remove it until we know what we want to achieve with it.
  • Loading branch information
tsodring committed Jul 24, 2023
1 parent b8bea71 commit 73bff1b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions runtest
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,7 @@ class Noark5Tester (n5core.endpoint.Endpoint):
urlseen[url] = 1
try:
(content, res) = self.json_get(url)
allow = res.getheader('Allow')
self.success("GET %s worked with code %d" % (url, res.code))
self.verify(allow is not None, "GET header should include Allow for %s" % url)
ctype = res.getheader('Content-Type')

if not ctype:
Expand Down

0 comments on commit 73bff1b

Please sign in to comment.