Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] added typing to materialize (breaks py27 tests) #559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[POC] added typing to materialize (breaks py27 tests) #559

wants to merge 1 commit into from

Conversation

MihanixA
Copy link

Proof of concept: typing for petl

Changes

  1. Added typing for some functions in materialize.py

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest (no new functions)
    • New functions are included in API docs (no new functions)
    • Docstrings include notes for any changes to API or behaviour (no changes in API behavior)
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@MihanixA MihanixA mentioned this pull request Jun 17, 2021
Open
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 91.313% when pulling d120c68 on MihanixA:poc-typing into 84c7b7f on petl-developers:master.

@juarezr juarezr mentioned this pull request Aug 31, 2021
Closed
17 tasks
@juarezr
Copy link
Member

juarezr commented Aug 31, 2021

PR #563 could drop python2.7, so referencing it here.

@juarezr juarezr mentioned this pull request Jan 31, 2022
Closed
@juarezr juarezr added Feature A nice to have thing that we don't have yet Usability Improvement that benefit petl usage for end users labels Jan 31, 2022
@juarezr juarezr added this to the v2.0 milestone Feb 5, 2022
@juarezr juarezr added the Help Wanted We are volunteers. We'll be happy if you join us. label Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature A nice to have thing that we don't have yet Help Wanted We are volunteers. We'll be happy if you join us. Usability Improvement that benefit petl usage for end users
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MihanixA @coveralls @juarezr