Apply pending upstream pull requests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied to formatted code Original commit found here opsb@e89a699
To check if everything builds, use the following bash commands: cd examples shopt -s globstar elm make **/*.elm
Original pull request here terezka#54 The typos in examples/Selection2.elm were tackled in terezka#61
terezka#46 Split this into two changes for easier diffing
terezka#46 Split this into two changes for easier diffing
Was originally printed with abbreviated formatting. Changed libraries here: terezka@a92d43d#diff-23c22c99a463689a572846b8c6f75331L321 Documentation reference to original: ``` %a - Day of week, abbreviated to three letters, e.g. "Wed" ``` https://github.com/mgold/elm-date-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating the following pull requests:
terezka#46
terezka#49
terezka#50
terezka#53
terezka#54
terezka#61
To the original authors, feel free to redirect your pull request at this repo directly if you would like better citation as the author (beyond a shoutout in the commit message).
I'm also happy to help reconsolidate any new code found in
peterszerzo/line-chartsback into theterezka/line-chartsupstream once pull requests resume being accepted.