Skip to content

Commit

Permalink
Fix variable name - again
Browse files Browse the repository at this point in the history
Signed-off-by: Peter Nied <[email protected]>
  • Loading branch information
peternied committed Oct 17, 2023
1 parent dc7b1ba commit 9ba5d34
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ runs:

- run: |
approvals_count=0
maintainers-padded=" ${{ inputs.maintainers }} " # Padding before and after for substring safety check below
maintainers_padded=" ${{ inputs.maintainers }} " # Padding before and after for substring safety check below
maintainer_approvals=""
for user in $approvers; do
# Match with strings padding the username on both sides to avoid substring matches
# e.g. maintainer named 'foo', someone creates a fake account named 'fake-foo' and approves
if [[ maintainers-padded == *" $user "* ]]; then
if [[ maintainers_padded == *" $user "* ]]; then
echo "Approval by maintainer: $user"
maintainer_approvals="$maintainer_approvals $user"
((approvals_count++))
Expand Down

0 comments on commit 9ba5d34

Please sign in to comment.