Change how mock approvers is processed

Signed-off-by: Peter Nied <[email protected]>
peternied · Dec 6, 2023 · 73dfc9b · 73dfc9b
1 parent 7dd6af2
commit 73dfc9b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -36731,10 +36731,10 @@ async function run() {
   }
 
   const requiredApprovers = core.getInput('required-approvers-list', { required: true })?.split(',').map(s => s.trim()).filter(a => a.length != 0);
-  const mockApprovers = core.getInput('mock-approvers', { required: false })?.split(' ') || [];
+  const mockApproversString = core.getInput('mock-approvers', { required: false, trimWhitespace: false });
 
-  let pullRequestApprovers = mockApprovers;
-  if (!pullRequestApprovers) {
+  let pullRequestApprovers;
+  if (mockApproversString !== "") {
     const client = github.getOctokit(token);
     const { data: reviewers } = await client.rest.pulls.listReviews({
         pull_number: pullRequestId,
@@ -36749,6 +36749,8 @@ async function run() {
     console.log(`filered to approvers:\n ${JSON.stringify(approvers)}`);
 
     pullRequestApprovers = approvers;
+  } else {
+    pullRequestApprovers = mockApprovers.split(' ');
   }
 
   const acceptedApprovers = [];

diff --git a/index.js b/index.js
@@ -22,10 +22,10 @@ async function run() {
   }
 
   const requiredApprovers = core.getInput('required-approvers-list', { required: true })?.split(',').map(s => s.trim()).filter(a => a.length != 0);
-  const mockApprovers = core.getInput('mock-approvers', { required: false })?.split(' ') || [];
+  const mockApproversString = core.getInput('mock-approvers', { required: false, trimWhitespace: false });
 
-  let pullRequestApprovers = mockApprovers;
-  if (!pullRequestApprovers) {
+  let pullRequestApprovers;
+  if (mockApproversString !== "") {
     const client = github.getOctokit(token);
     const { data: reviewers } = await client.rest.pulls.listReviews({
         pull_number: pullRequestId,
@@ -40,6 +40,8 @@ async function run() {
     console.log(`filered to approvers:\n ${JSON.stringify(approvers)}`);
 
     pullRequestApprovers = approvers;
+  } else {
+    pullRequestApprovers = mockApprovers.split(' ');
   }
 
   const acceptedApprovers = [];