Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new user auth #622

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix: new user auth #622

merged 1 commit into from
Dec 27, 2024
+3 −3

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Dec 27, 2024

  • 修复新增用户的问题

@vercel Vercel
Copy link

vercel bot commented Dec 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:21am

@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

此PR修复了新增用户时可能出现的问题。主要修改包括在处理用户信息时，增加了对profile对象的存在性检查，以避免潜在的空引用错误。此外，还修复了从数据库获取用户数据时可能出现的空数据返回问题。

Changes

文件 摘要
server/auth/router.py 增加了对profile对象的存在性检查，确保在profile为空时不会导致错误。
server/core/dao/profilesDAO.py 修复了当数据库查询结果为空时返回None而不是抛出异常的问题。

xingwanying
xingwanying approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/core/dao/profilesDAO.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
server/auth/router.py 37.50% <ø> (+0.91%) ⬆️
server/core/dao/profilesDAO.py 37.50% <0.00%> (ø)

@RaoHai RaoHai merged commit a95633e into main Dec 27, 2024
4 of 5 checks passed
@RaoHai RaoHai deleted the fix/new-user-auth branch December 27, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

@xingwanying xingwanying xingwanying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaoHai @xingwanying