Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(install): Refactor GitHub App Installation Logic #581

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

xingwanying
Copy link
Contributor

TODO: 部署上线验证无误后可以删除 github_app_authorization 表及其类型定义和引用

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:58am

Copy link

Walkthrough: 本次PR重构了GitHub APP的安装逻辑,增加了批量删除和添加repository的方法,替代了原有的for循环入库逻辑。同时,新增了InstallationEditEventHandler以响应Repository访问的编辑逻辑。

Changes:

文件 概要
server/core/dao/repositoryConfigDAO.py 重构了repositoryDAO,增加了批量删除和添加的方法,替代了for循环入库。
server/event_handler/intsall.py 重命名并重构了InstallEventHandler,新增了InstallationEditEventHandler以处理Repository访问的编辑逻辑。
server/github_app/handlers.py 更新了事件处理程序的导入和使用逻辑。
server/github_app/router.py 简化了GitHub APP安装回调的处理逻辑。

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/core/dao/repositoryConfigDAO.py 25.00% 18 Missing ⚠️
server/event_handler/intsall.py 22.22% 7 Missing ⚠️
server/github_app/router.py 0.00% 4 Missing ⚠️
server/github_app/handlers.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
server/github_app/handlers.py 81.81% <50.00%> (+1.81%) ⬆️
server/github_app/router.py 36.36% <0.00%> (ø)
server/event_handler/intsall.py 42.30% <22.22%> (ø)
server/core/dao/repositoryConfigDAO.py 34.88% <25.00%> (-3.36%) ⬇️

... and 2 files with indirect coverage changes

@RaoHai RaoHai merged commit 613ee11 into main Dec 10, 2024
4 of 5 checks passed
@RaoHai RaoHai deleted the fix_install_edit branch December 10, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub 仓库安装变更回调无响应 无法找到关联github仓库
2 participants