Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle the uninstall action #572

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: handle the uninstall action #572

merged 1 commit into from
Dec 6, 2024

Conversation

xingwanying
Copy link
Contributor

close #563

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 9:16am

Copy link

Walkthrough

This pull request introduces functionality to handle the uninstall action by adding a new method to delete repository configurations based on repository IDs. It also integrates an event handler to manage installation events, specifically handling the deletion of configurations when a repository is uninstalled.

Changes

File Summary
server/core/dao/repositoryConfigDAO.py Added a method delete_by_repo_ids to delete repository configurations by repository IDs.
server/event_handler/intsall.py Introduced InstallEventHandler class to handle installation events and delete configurations when repositories are uninstalled.
server/github_app/handlers.py Integrated InstallEventHandler into the event handlers to manage installation events.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/core/dao/repositoryConfigDAO.py 0.00% 1 Missing ⚠️
server/github_app/handlers.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
server/core/dao/repositoryConfigDAO.py 35.00% <0.00%> (-3.24%) ⬇️
server/github_app/handlers.py 80.00% <50.00%> (ø)

... and 2 files with indirect coverage changes

@xingwanying xingwanying merged commit 5401bef into main Dec 6, 2024
4 of 5 checks passed
@xingwanying xingwanying deleted the feat_uninstall branch December 6, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub repo uninstall 时的回调响应
1 participant