Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deployment): optimize the deployment robot popup form modal #558

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

ch-liuzhide
Copy link
Contributor

@ch-liuzhide ch-liuzhide commented Dec 3, 2024

default status
image

click btn then show deployment form
image

The confirm button can be clicked after filling out the form.
image

close #538

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 3:10am

Copy link

Walkthrough

This pull request refactors the deployment robot popup form modal to enhance its functionality and user interaction. Key changes include the addition of new status enums, improved button rendering logic, and updates to the language files for better localization support.

Changes

Files Summary
client/.kiwi/en/DeployBotModal.ts, client/.kiwi/ja/DeployBotModal.ts, client/.kiwi/ko/DeployBotModal.ts, client/.kiwi/zh-CN/DeployBotModal.ts, client/.kiwi/zh-TW/DeployBotModal.ts Added new localization strings for deployment statuses and actions.
client/app/factory/edit/components/DeployBotModal/DeployContent.tsx Removed unused span element related to deployment content.
client/app/factory/edit/components/DeployBotModal/index.tsx Introduced DeployStatusEnum to manage deployment status, added logic for rendering footer buttons based on deployment status, and updated modal body rendering.
client/public/images/chevron-down.svg, client/public/images/chevron-up.svg Added new SVG images for UI elements.
server/github_app/router.py Refactored function to use github_user.get_orgs() instead of get_user_orgs().

@xingwanying xingwanying merged commit 3d3fbc2 into main Dec 4, 2024
3 of 4 checks passed
@xingwanying xingwanying deleted the feat/deployment branch December 4, 2024 07:45
@afc163
Copy link
Contributor

afc163 commented Dec 5, 2024

👍🏻

@afc163
Copy link
Contributor

afc163 commented Dec 5, 2024

图片

这个界面时没有关闭弹窗按钮,用户想不做任何操作直接离开没有路径。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

保存结果弹窗像是二次确认框,比较难理解
3 participants