-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: issue task control #327
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis PR introduces enhancements to the issue task control mechanism, including the addition of new task types and improved handling of GitHub issues. It also refines the task creation and status update processes. Changes
|
|
||
return self.update_status(TaskStatus.COMPLETED) | ||
|
||
def handle_issue_page_node(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handle_issue_page_node
method does not handle the case where repo.get_issues(state='all').get_page(self.page_index)
returns an empty list. This could lead to potential errors when processing issues.
|
||
existing_issue_ids = {int(issue['issue_id']) for issue in existing_issues.data} | ||
|
||
new_task_list = [item for item in task_list if item['issue_id'] not in existing_issue_ids] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new_task_list
is created without checking if task_list
is empty. This could lead to unnecessary database operations if task_list
is empty.
Codecov ReportAttention: Patch coverage is
|
6cb63be
to
5cf5f06
Compare
No description provided.