Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert envs #272

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: revert envs #272

merged 1 commit into from
Aug 30, 2024

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Aug 30, 2024

  • 好像不太对

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 8:00am

Copy link

Walkthrough: This PR reverts changes related to environment variables in Dockerfiles and a utility script, aiming to correct an issue.

Changes:

File Summary
docker/Dockerfile.aws.lambda, docker/Dockerfile.subscriber Removed the ENV=production environment variable setting.
petercat_utils/utils/env.py Simplified the load_env function by removing conditional loading based on the ENV variable.


if env == 'development':
load_dotenv(dotenv_path=".env.local", verbose=True, override=True)
load_dotenv(verbose=True, override=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the ENV variable and its conditional logic might lead to issues if different environments require different configurations. Consider adding a fallback or ensuring that the .env.local file is suitable for all environments.

Copy link

filepath function passed SUBTOTAL
tests/aws/test_upload.py test_upload_image_success 1 1
tests/aws/test_upload.py test_upload_image_error 1 1
tests/test_main.py test_health_checker 1 1
tests/utils/test_path_to_hunk.py TestPathToHunk.test_basic_covnert 1 1
tests/utils/test_path_to_hunk.py TestPathToHunk.test_parse 1 1
TOTAL 5 5

@RaoHai RaoHai merged commit 6875ee9 into main Aug 30, 2024
4 checks passed
@RaoHai RaoHai deleted the fix/revert-envs branch August 30, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant