Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Cem Aksoylar <[email protected]>
  • Loading branch information
petejohanson and caksoylar authored Nov 11, 2024
1 parent cef4e68 commit 3978eeb
Showing 1 changed file with 25 additions and 25 deletions.
50 changes: 25 additions & 25 deletions docs/docs/development/contributing/commit-messages.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ Commit messages will be checked as part of our CI process by GitHub Actions.

Commits should have the following:

- A first line prefix that includes a [type](#types), as well as appropriate [scope](#scopes) as needed
- Following the prefix, a concise summary of the change, which documents the new behavior/feature/functionality in the positive (e.g. "wake from sleep now works with charlieplex kscan", not "fixed waked from sleep bug with charlieplex kscan driver")
- A first line prefix that includes a [type](#types), as well as appropriate [scope](#scopes) in parentheses as needed.
- Following the prefix, a concise summary of the change, which documents the new behavior/feature/functionality in the positive (e.g. "wake from sleep now works with charlieplex kscan", not "fixed waked from sleep bug with charlieplex kscan driver").
- A blank line following the first line.
- A body that provides more detail of the changes. This MAY be a bulleted list or paragraph prose.
- A body that provides more detail of the changes. This *may* be a bulleted list or paragraph prose.
- An optional set of [git trailers](https://git-scm.com/docs/git-interpret-trailers#_description) for things like [GitHub keywords](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests) following a blank line.

## Example

Here is an example good commit message:
Here is an example of a good commit message:

```
feat(boards): Add numpad layouts
Expand All @@ -42,29 +42,29 @@ To help make sure you don't need to wait for GitHub Actions to check your commit

The following commit types are used by ZMK:

- `blog:` - changes to our documentation found in the `docs/blog` directory.
- `docs:` - changes to our documentation found in the `docs/` directory.
- `feat:` - changes that add a new feature
- `fix:` - changes that fix existing functionality
- `refactor:` - changes that refactor existing functionality without adding any new features
- `feat!:`/`refactor!:`/`fix!` - same as above, but indicate a breaking change. Examples would be changes to the public C API, renaming a board/shield, editing a board or shield to rename devicetree labels that may be used in keymaps, etc.
- `ci:` - changes to our continuous integration setup with GitHub Actions, usually only for the files in `.github/workflows/`.
- `chore:` - grab bag type for small changes that don't fall into any of the above categories.
- `blog:` -- changes to our documentation found in the `docs/blog` directory
- `docs:` -- changes to our documentation found in the `docs/` directory, except blogs
- `feat:` -- changes that add a new feature
- `fix:` -- changes that fix existing functionality
- `refactor:` -- changes that refactor existing functionality without adding any new features
- `feat!:`/`refactor!:`/`fix!:` -- same as above, but indicates a breaking change. Examples would be changes to the public C API, renaming a board/shield, editing a board or shield to rename devicetree labels that may be used in keymaps, etc.
- `ci:` -- changes to our continuous integration setup with GitHub Actions, usually only for the files in `.github/workflows/`
- `chore:` -- grab bag type for small changes that don't fall into any of the above categories, including dependency updates for development tools and docs.

## Scopes

The following scopes are frequently used to further clarify the scope of the change:

- `hid` - changes to our general HID code
- `usb` - changes specific to USB
- `ble` - changes specific to BLE
- `power` - changes to our power management code
- `split` - changes to our split keyboard support
- `studio` - changes to our ZMK Studio code
- `display` - changes to to our display code
- `underglow` - changes to to our RGB underglow support
- `backlight` - changes to to our simple LED backlight support
- `behaviors` - changes to to our core behavior code
- `core` - changes to any other area of our core code
- `boards` - changes to the in-tree boards
- `shields` - changes to the in-tree shields
- `hid` -- changes to our general HID code
- `usb` -- changes specific to USB
- `ble` -- changes specific to BLE
- `power` -- changes to our power management code
- `split` -- changes to our split keyboard support
- `studio` -- changes to our ZMK Studio code
- `display` -- changes to to our display code
- `underglow` -- changes to to our RGB underglow support
- `backlight` -- changes to to our simple LED backlight support
- `behaviors` -- changes to to our core behavior code
- `core` -- changes to any other area of our core code
- `boards` -- changes to the in-tree boards
- `shields` -- changes to the in-tree shields

0 comments on commit 3978eeb

Please sign in to comment.