-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: tags on silent rules #55
Conversation
WalkthroughThe changes enhance the documentation regarding the usage of tags within grammar rules. Key clarifications include the necessity for tagged parts of rules to be non-silent, warnings about enabling the "grammar-extras" feature, and examples illustrating the impact of silent rules on tagging. These updates aim to improve user understanding of tag interactions in grammar definitions. Changes
Sequence Diagram(s)(No sequence diagrams generated as the changes do not warrant visual representation of control flow.) Poem
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/grammars/syntax.md (1 hunks)
Additional context used
LanguageTool
src/grammars/syntax.md
[uncategorized] ~445-~445: You might be missing the article “the” here.
Context: ...II } ``` [!WARNING] You need to enable "grammar-extras" feature to use this func...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
Additional comments not posted (4)
src/grammars/syntax.md (4)
429-430
: LGTM!The note provides important information about the limitation of using tags with silent rules.
432-435
: LGTM!The example clearly illustrates the limitation of using tags with silent rules.
437-442
: LGTM!The information and example provide additional context about the limitation of using tags with built-in rules.
444-445
: LGTM!The warning provides important information about the configuration required to use the tags functionality.
Tools
LanguageTool
[uncategorized] ~445-~445: You might be missing the article “the” here.
Context: ...II } ``` [!WARNING] You need to enable "grammar-extras" feature to use this func...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Tags do not work on silent rules see: pest-parser/pest#1035
This adds some documentation for that.
I also added a warning label for the grammar-extras feature, though, not certain this is supported.
Summary by CodeRabbit