Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to skip acquisition on error #144

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Aug 28, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

Sometimes, even though acquisition succeeds, the robot thinks it encountered an error. This PR shows the user the option to proceed to the resting position even if it gets an error, to account for that scenario.

Explain how this pull request was tested, including but not limited to the below checkmarks.

  • Launch code in sim mock.
  • Before running acquisition, terminate the code in the feeding screen. Run acquisition.
  • Verify that it encounters an error and the "Skip Acquisition" button appears (but resume and retry don't).
  • Re-run the code in the feeding screen.
  • Click "Skip Acquisition" and verify it moves to the resting configuration.
  • Move to some other configuration (e.g., to staging) and cause an error e.g., terminating the code in the feeding screen before calling it).
  • Verify that the retry, resume, and back buttons appear.
  • Re-run the code in the feeding screen.
  • Click retry, verify it works.
  • Pause some motion (e.g., moving to resting). Verify back and resume appear.
  • Verify back works.
  • Verify resume works.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit 98ca809 into main Aug 28, 2024
4 checks passed
@amalnanavati amalnanavati deleted the amaln/skip_acquisition branch August 28, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant