Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to customize the stow configuration #141

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented May 15, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

This PR builds off of recent PRs (#136 , #135 , etc.) to allow users to customize the stow configuration.

Explain how this pull request was tested, including but not limited to the below checkmarks.

  • Launch the code in real: python3 src/ada_feeding/start.py
  • Ideally, sit in the wheelchair for all the below tests to ensure it feels safe.
  • Verify Stow Position Settings work:
    • Regardless of what page you go to the Stow Position settings from, verify it moves to the stow position when you load it and moves back when you click "Done"
      • Bite Selection
      • Bite Acquisition Check
      • Detecting Face
      • Bite Done
    • Teleop it, verify the parameters in the YAML file update.
    • Click MoveAbovePlate. Verify it succeeds, and after that the teleop part is disabled.
    • Click Stow Arm, and verify the teleop part gets re-enabled. Verify it moves to the customized stow configuration.
    • Reset to default, verify that it updates the param file and immediately moves to the default stow configuration.
  • Find reasonable stow configurations for each of the default side configurations.

Before creating a pull request

  • Format React code with npm run format
  • [N/A] Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit 1d295fc into main Aug 14, 2024
4 checks passed
@amalnanavati amalnanavati deleted the amaln/customize_stow branch August 14, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant