Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Above the Plate Data #129

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Add New Above the Plate Data #129

merged 6 commits into from
Mar 28, 2024

Conversation

sriramk117
Copy link
Contributor

@sriramk117 sriramk117 commented Mar 28, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

This pull request adds 9 new images taken through teleop control of the robot above the plate and 2 new images taken from the real above plate configuration as data.

Explain how this pull request was tested, including but not limited to the below checkmarks.

The pull request was tested by ensuring that the general functionality of the web app stays the same and that the desired images appeared on the web app when launching the dummy nodes for testing purposes.


Before creating a pull request

  • [N\A, I did not modify any React code] Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • [N\A] Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • [N\A, I did not change any workflows] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@sriramk117 sriramk117 self-assigned this Mar 28, 2024
@amalnanavati amalnanavati self-requested a review March 28, 2024 16:17
Copy link
Contributor

@amalnanavati amalnanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sriramk117 sriramk117 merged commit 12f2904 into main Mar 28, 2024
4 checks passed
@sriramk117 sriramk117 deleted the sriramk/new_teleoped_data branch March 28, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants