Add --only-metadata option to prevent falling back to other ADC sources #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcapulet
force-pushed
the
alexc-only-metadata
branch
from
0c2a2ab
to
fcaa90d
Compare
derektamsen
reviewed
Mar 20, 2024
| @@ -99,6 +119,7 @@ func parseConfiguration() (*Config, error) { | |||
| viper.GetViper().SetDefault("listen", "localhost:8000") | |||
|
|
|||
| pflag.String("listen", "", "Address for the mirror to listen on.") | |||
| pflag.Bool("only-metadata", false, "Only rely upon on the GCE metadata server for authentication.") | |||
There was a problem hiding this comment.
nit:
Suggested change
| pflag.Bool("only-metadata", false, "Only rely upon on the GCE metadata server for authentication.") | |
| pflag.Bool("only-metadata", false, "Only rely upon the GCE metadata server for authentication.") |
derektamsen
approved these changes
Mar 20, 2024
If running in CI and a step does a GCP login using a different service account, those credentials will get picked up over the node's service which is likelier the preferred account to use since it stays constant.
drcapulet
force-pushed
the
alexc-only-metadata
branch
from
fcaa90d
to
067fedd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running in CI and a step does a GCP login using a different service account, those credentials will get picked up over the node's service which is likelier the preferred account to use since it stays constant.