Moved everything from register.php into a class #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! @perrybutler , when will accept this pull request? |
|
@vitormattos @perrybutler This PR should be OK, but i kind of diverged quite a lot of the main code in order to make things to fit my needs (e.g. make possible to hook on registration process and add various extra steps): https://github.com/iamntz/WP-OAuth/tree/complete-fb-flow Unfortunately, things might diverged too much to be possible to merge into main repo. |
|
Appreciate the pull requests, I will have a look at this and the others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored
register.phpcompletely:I only tested with FB auth; probably it's a good idea to test with other providers first before merging :)