Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial modules #1

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Initial modules #1

merged 5 commits into from
Jan 9, 2024

Conversation

alejandrohdezma
Copy link
Contributor

💻 How to review this PR?

This PR was created with the idea of being reviewed commit by commit. Each commit contains an incremental change that makes it easier to review. Also some of the commits contain additional information in their description to help understand why the change was made.

I also recommend checking "Hide whitespace" when reviewing this PR!

🚀 What's included in this PR?

This PR initializes the library with a module containing the methods to retrieve tokens from GCP and a second module simplifying pureconfig integration.

@alejandrohdezma alejandrohdezma requested a review from a team as a code owner January 9, 2024 15:40
@github-actions github-actions bot added 🚀 feature New feature or improvement ⚖️ XL Size of PR between 1000 and 2000 lines labels Jan 9, 2024
Copy link

@janstenpickle janstenpickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But before releasing we should add the mima plugin

@alejandrohdezma
Copy link
Contributor Author

LGTM! But before releasing we should add the mima plugin

I'll add a second PR just with that

@alejandrohdezma alejandrohdezma merged commit 22902f7 into main Jan 9, 2024
4 checks passed
@alejandrohdezma alejandrohdezma deleted the feature/initial-modules branch January 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚖️ XL Size of PR between 1000 and 2000 lines 🚀 feature New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants