Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDP Setup (in CI and in general) #196

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

roekatz
Copy link
Contributor

@roekatz roekatz commented Oct 9, 2024

  1. Fixed setup.py so it would install dev packages (pytest etc...) as extra requirement (if installed like pip install horizon[dev])
  2. Fixed CI to not install requirements in few stages (that created collision errors because not all dependencies were calculated together at a single time).
  3. Fixed sub-package recognition by adding __init__.py files - such that setting PYTHONPATH in CI won't be necessary for package to function.
  4. Removed deprecated dev requirements.

https://linear.app/permit/issue/PER-10888/fix-pdp-setup-in-ci-and-in-general

…t one step

Otherwise collisions happen.
Running `pip install .` would install all requirements,
Running `pip install ".[dev]"` would install all requirements for dev & testing.
@roekatz roekatz force-pushed the roe/per-10888-fix-pdp-setup-in-ci-and-in-general branch from cd15f5f to 9374546 Compare October 9, 2024 12:49
@roekatz roekatz force-pushed the roe/per-10888-fix-pdp-setup-in-ci-and-in-general branch from 9374546 to 81ad9cc Compare October 9, 2024 12:50
Copy link
Contributor

@omer9564 omer9564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roekatz roekatz merged commit baba618 into v2 Oct 9, 2024
3 checks passed
@roekatz roekatz deleted the roe/per-10888-fix-pdp-setup-in-ci-and-in-general branch October 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants