-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the initial version of "Annotating Chrismas Trees" #480
Conversation
Thank you very much for your contribution. I have unfortunately come up against some time constraints and I don't have the resources to dedicate to another 12 or so proper article reviews. If we don't get a review in, your article will still get merged, but I'll likely only have time to look for typos and ensure formatting is mostly correct. If you know of a peer who would be willing to review your work, I'd encourage you to ask them to leave a review on this pull request. If you find yourself with any extra time, feel free to self-assign any outstanding Advent pull request(s) and leave a helpful review. The editing guidelines should be helpful in this regard. Basically the situation this year is that most articles arrived in late November/early December, meaning that there is now a bottleneck at this time of year which is busy for many of us. This is not a judgement on anyone -- all articles are welcome and I always expect some to come in later in the game. In fact, there are still more articles to come which do not yet have pull requests. In order to ensure that everyone's content gets a fair chance for review, I'm looking to cast a wider net. Hopefully spreading the effort around this way will help us continue the tradition of high value Advent articles in 2025. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if the tool is actually written in Perl, I'd like to see a bit of more Perl here... As in code.
=head2 Lesser-known businesses | ||
|
||
Everybody knows that the North Pole™ produces and delivers Christmas gifts, | ||
but it’s not the sole business they’re into. In fact, they’ve recently engaged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to use the full expression in (roughly) formal writing, as in "it is" and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the article is a formal writing.
“Let’s meet after the lunch and see how we can share the knowledge,” commanded | ||
Santa. | ||
|
||
=head2 There’s trees and there’s trees |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is an expression, keep it that way. But if it's not, maybe you'd want to use "There are"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A native speaker needed to judge. I've read this expression somewhere (it mentioned "cars", so plural), but I have no idea how common it is.
and summer was over) Santa met with the COO and CCO (where the second letter | ||
stands for Ornaments or Cards, respectively). | ||
|
||
“Can you show us what your department uses to visualise trees?” asked Santa, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning to British spelling, are we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I keep it through the whole article 🇬🇧
@choroba do you know when you'll be able to look at the review comments? |
I tried to resolve most of them, see above. |
Fixes #437.