-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize (thanks ChatGPT), remove jQuery, add README. #18
Conversation
will take a look somewhere this week, build is failing at this moment not sure why though |
The CI lacks SSH keys to Github so that it could clone (and presumably also push to after update) gh-pages. This happens in local-deploy.sh:
|
The showcase image scroller should really be done with CSS animation, but ChatGPT didn't provide correct code for that change, so I left the JS implementation (but at least it uses requestAnimationFrame to run smoother). |
Also this way of updating keeps old files that previously existed in gh-pages (such as the deleted jQuery files that GitHub keeps sending me warnings of). I suggest you put all static files in htdocs-binary, remove that git clone from the script such that no old files are placed in the generated web folder, and change your CI so that it deleted all old files and then adds the files from the web folder (I think git will still track changes as modifications if the same file was deleted and added in the same commit). |
Still getting those jQuery security alerts. Could you get this deployed please? |
@Baklap4 Hello? |
@Tronic I tried to see what the issue with Semaphore was, but it never loads the log or anything when I look at it. I do have a task to convert this over to GitHub Actions at some point. I did start a new job a few weeks ago, so I'm pretty busy at the moment, but I'm hoping I will get to it soon. If this PR isn't merged by that point then I'll ping you again, and we can rebase and get it moving. |
@Tronic i've rebased this on to current master. This will make sure GH-Actions run and i can try it out locally. If all is well it'll get merged right away. Thanks for updating sources! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @Tronic
Nothing needs to be done anymore since we auto-deploy the website now. Thanks :)
Avoid security warnings about jQuery.