Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize (thanks ChatGPT), remove jQuery, add README. #18

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented May 9, 2023

Avoid security warnings about jQuery.

@Tronic Tronic requested a review from Baklap4 May 9, 2023 14:52
@Baklap4
Copy link
Member

Baklap4 commented May 9, 2023

will take a look somewhere this week, build is failing at this moment not sure why though

@Tronic
Copy link
Member Author

Tronic commented May 9, 2023

The CI lacks SSH keys to Github so that it could clone (and presumably also push to after update) gh-pages. This happens in local-deploy.sh:

git clone --depth=50 --branch=gh-pages [email protected]:performous/web.git

@Tronic
Copy link
Member Author

Tronic commented May 9, 2023

The showcase image scroller should really be done with CSS animation, but ChatGPT didn't provide correct code for that change, so I left the JS implementation (but at least it uses requestAnimationFrame to run smoother).

@Tronic
Copy link
Member Author

Tronic commented May 9, 2023

Also this way of updating keeps old files that previously existed in gh-pages (such as the deleted jQuery files that GitHub keeps sending me warnings of). I suggest you put all static files in htdocs-binary, remove that git clone from the script such that no old files are placed in the generated web folder, and change your CI so that it deleted all old files and then adds the files from the web folder (I think git will still track changes as modifications if the same file was deleted and added in the same commit).

@Tronic
Copy link
Member Author

Tronic commented May 24, 2023

Still getting those jQuery security alerts. Could you get this deployed please?

@Tronic
Copy link
Member Author

Tronic commented Jun 6, 2023

@Baklap4 Hello?

@ooshlablu
Copy link
Member

@Tronic I tried to see what the issue with Semaphore was, but it never loads the log or anything when I look at it. I do have a task to convert this over to GitHub Actions at some point. I did start a new job a few weeks ago, so I'm pretty busy at the moment, but I'm hoping I will get to it soon. If this PR isn't merged by that point then I'll ping you again, and we can rebase and get it moving.

@Baklap4
Copy link
Member

Baklap4 commented Aug 6, 2023

@Tronic i've rebased this on to current master. This will make sure GH-Actions run and i can try it out locally. If all is well it'll get merged right away. Thanks for updating sources!

htdocs-source/Model.htm Outdated Show resolved Hide resolved
htdocs-binary/js/main.js Show resolved Hide resolved
Copy link
Member

@Baklap4 Baklap4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Tronic

Nothing needs to be done anymore since we auto-deploy the website now. Thanks :)

@Baklap4 Baklap4 merged commit 627c201 into master Aug 6, 2023
2 checks passed
@Baklap4 Baklap4 deleted the modernize branch August 6, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants