Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n support, some code cleanup #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add i18n support, some code cleanup #1

wants to merge 1 commit into from

Conversation

sekrett
Copy link

@sekrett sekrett commented Feb 23, 2011

Hi!

Now it supports i18n translations. I also removed some lines, but all tests pass.


This change is Reviewable

@sekrett
Copy link
Author

sekrett commented Feb 23, 2011

Here is an i18n example:

ru:
  activerecord:
    errors:
      models:
        page:
          attributes:
            from_email:
              invalid_email: "некорректный e-mail"

I don't know, why do I have to write translation for every model I have, but it works the same way on validates_as_email_address and validates_email_format_of.

@kritik
Copy link
Member

kritik commented Oct 30, 2013

If you update code I'll merge your request. Anyway thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants