-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
ORDER BY period_start DESC;` | ||
|
||
// SelectPGSMSettings selects settings for given queryid. | ||
func (m *Metrics) SelectPGSMSettings(ctx context.Context, periodStartFromSec, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci-lint] reported by reviewdog 🐶
Function 'SelectPGSMSettings' is too long (67 > 60) (funlen)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also same for another methods here.
@@ -343,3 +343,44 @@ func (s *Service) GetHistogram(ctx context.Context, in *qanpb.HistogramRequest) | |||
|
|||
return resp, nil | |||
} | |||
|
|||
// GetPGSMSettings gets pg_stat_monitor settings for given queryid. | |||
func (s *Service) GetPGSMSettings(ctx context.Context, in *qanpb.SettingsRequest) (*qanpb.SettingsReply, error) { //nolint:dupl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci-lint] reported by reviewdog 🐶
parameter name 'in' is too short for the scope of its usage (varnamelen)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this name "in" also in another methods here.
PMM-9632
Build: SUBMODULES-0
PMM-9632 Settings view usage. pmm-agent#374
PMM-9632 Settings view usage. pmm-managed#1107
PMM-9632 Settings view usage. pmm#886