This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
PMM-9632 Settings view usage. #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ORDER BY period_start DESC;` | ||
|
|
||
| // SelectPGSMSettings selects settings for given queryid. | ||
| func (m *Metrics) SelectPGSMSettings(ctx context.Context, periodStartFromSec, |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Function 'SelectPGSMSettings' is too long (67 > 60) (funlen)
There was a problem hiding this comment.
Also same for another methods here.
| @@ -343,3 +343,44 @@ func (s *Service) GetHistogram(ctx context.Context, in *qanpb.HistogramRequest) | |||
|
|
|||
| return resp, nil | |||
| } | |||
|
|
|||
| // GetPGSMSettings gets pg_stat_monitor settings for given queryid. | |||
| func (s *Service) GetPGSMSettings(ctx context.Context, in *qanpb.SettingsRequest) (*qanpb.SettingsReply, error) { //nolint:dupl | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
parameter name 'in' is too short for the scope of its usage (varnamelen)
There was a problem hiding this comment.
We have this name "in" also in another methods here.
This was referenced May 10, 2022
percona-csalguero
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9632
Build: SUBMODULES-0
PMM-9632 Settings view usage. pmm-agent#374
PMM-9632 Settings view usage. pmm-managed#1107
PMM-9632 Settings view usage. pmm#886