PMM-5086-12634 Agent model refactor. #3338
Conversation
|
|
||
| if !pmmAgentVersion.Less(postgresExporterCollectorsVersion) { | ||
| disableCollectorArgs := collectors.DisableDefaultEnabledCollectors("--no-collector.", defaultPostgresExporterCollectors, exporter.DisabledCollectors) | ||
| disableCollectorArgs := collectors.DisableDefaultEnabledCollectors("--no-collector.", defaultPostgresExporterCollectors, exporter.ExporterOptions.DisabledCollectors) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
the line is 173 characters long, which exceeds the maximum of 170 characters. (lll)
| func (c *AWSOptions) Scan(src interface{}) error { return jsonScan(c, src) } | ||
|
|
||
| // AzureOptions represents structure for special Azure options. | ||
| type AzureOptions struct { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
the methods of "AzureOptions" use pointer receiver and non-pointer receiver. (recvcheck)
| func (c *ExporterOptions) Scan(src interface{}) error { return jsonScan(c, src) } | ||
|
|
||
| // QANOptions represents structure for special QAN options. | ||
| type QANOptions struct { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
the methods of "QANOptions" use pointer receiver and non-pointer receiver. (recvcheck)
| func (c *QANOptions) Scan(src interface{}) error { return jsonScan(c, src) } | ||
|
|
||
| // AWSOptions represents structure for special AWS options. | ||
| type AWSOptions struct { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
the methods of "AWSOptions" use pointer receiver and non-pointer receiver. (recvcheck)
| TenantID string `json:"tenant_id"` | ||
| ResourceGroup string `json:"resource_group"` | ||
| // MySQLOptions represents structure for special MySQL options. | ||
| type MySQLOptions struct { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
the methods of "MySQLOptions" use pointer receiver and non-pointer receiver. (recvcheck)
| TLSCert string `json:"tls_cert"` | ||
| TLSKey string `json:"tls_key"` | ||
| // ExporterOptions represents structure for special Exporter options. | ||
| type ExporterOptions struct { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
the methods of "ExporterOptions" use pointer receiver and non-pointer receiver. (recvcheck)
| if pointer.GetString(exporter.MetricsPath) != "" { | ||
| args = append(args, "--web.telemetry-path="+*exporter.MetricsPath) //nolint:goconst | ||
| if exporter.ExporterOptions != nil && exporter.ExporterOptions.MetricsPath != "" { | ||
| args = append(args, "--web.telemetry-path="+exporter.ExporterOptions.MetricsPath) //nolint:goconst |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:goconst is unused for linter "goconst" (nolintlint)
PMM-5086
PMM-12634