PMM-12915 consistent proto validation rules #3190
Draft
+3,393
−2,916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3190 +/- ##
=======================================
Coverage 44.51% 44.51%
=======================================
Files 357 357
Lines 35594 35594
=======================================
Hits 15844 15844
Misses 18127 18127
Partials 1623 1623
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
force-pushed
the
v3
branch
2 times, most recently
from
4b06c24
to
6a7efaf
Compare
|
wow, great work |
Maybe, but it was not safe to go ahead with it, so I mentioned the blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12915
Link to the Feature Build: SUBMODULES-0
NOTE: we can't go ahead with this PR because of the blocking PMM-13335.