Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

PMM-8306 migrate ami ova to docker #343

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

nikita-b
Copy link
Contributor

No description provided.

packer/ansible/roles/lvm-init/tasks/main.yml Outdated Show resolved Hide resolved
packer/ansible/roles/lvm-init/tasks/main.yml Outdated Show resolved Hide resolved
packer/ansible/roles/lvm-init/tasks/main.yml Show resolved Hide resolved
@nikita-b nikita-b requested a review from ademidoff March 16, 2022 09:20
[Service]
TimeoutStartSec=0
Restart=always
ExecStartPre=-/usr/bin/docker exec pmm-server stop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be just /usr/bin/docker stop pmm-server?

TimeoutStartSec=0
Restart=always
ExecStartPre=-/usr/bin/docker exec pmm-server stop
ExecStartPre=-/usr/bin/docker rm pmm-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove pmm-server on each start? Looks like if the user upgrades PMM using the UI button and then restart the service, the service might use an incorrect image.


variable "pmm_server_image_name" {
type = string
default = "perconalab/pmm-server:dev-latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we implement this feature for internal usage or for public?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants