This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
PMM-8306 migrate ami ova to docker #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademidoff
reviewed
Feb 28, 2022
ademidoff
suggested changes
Mar 16, 2022
Co-authored-by: Alex Tymchuk <[email protected]>
…na/pmm-server into PMM-8306-migrate-ami-ova-to-docker
ademidoff
approved these changes
Mar 16, 2022
ademidoff
approved these changes
May 4, 2022
…grate-ami-ova-to-docker
BupycHuk
reviewed
Jun 2, 2022
| [Service] | ||
| TimeoutStartSec=0 | ||
| Restart=always | ||
| ExecStartPre=-/usr/bin/docker exec pmm-server stop |
There was a problem hiding this comment.
shouldn't it be just /usr/bin/docker stop pmm-server?
| TimeoutStartSec=0 | ||
| Restart=always | ||
| ExecStartPre=-/usr/bin/docker exec pmm-server stop | ||
| ExecStartPre=-/usr/bin/docker rm pmm-server |
There was a problem hiding this comment.
Why do we remove pmm-server on each start? Looks like if the user upgrades PMM using the UI button and then restart the service, the service might use an incorrect image.
|
|
||
| variable "pmm_server_image_name" { | ||
| type = string | ||
| default = "perconalab/pmm-server:dev-latest" |
There was a problem hiding this comment.
Do we implement this feature for internal usage or for public?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.