This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
PMM-9634 Timestamp bucket_start_time for newer versions. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 2 commits
March 10, 2022 12:31
| @@ -106,7 +106,7 @@ type field struct { | |||
| pointer interface{} | |||
| } | |||
|
|
|||
| func NewPgStatMonitorStructs(v pgStatMonitorVersion) (*pgStatMonitor, reform.View) { | |||
| func NewPgStatMonitorStructs(v pgStatMonitorVersion, p pgStatMonitorPrerelease) (*pgStatMonitor, reform.View) { | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Function 'NewPgStatMonitorStructs' is too long (114 > 60) (funlen)
|
2 failed tests are not related to PR. See empty PR failed on same tests here: #328 |
percona-csalguero
approved these changes
Mar 10, 2022
BupycHuk
approved these changes
Mar 10, 2022
1 task
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9634
Build: SUBMODULES-0
Branch is based on 9630.