Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune CI triggers #444

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Tune CI triggers #444

merged 5 commits into from
Apr 18, 2024

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Apr 8, 2024

This PR sets same CI triggers for all workflows. It triggers all workflows on push in main branch, push of release tags and in Pull Requests. With that change we will be able to compare state of CI in feature PRs with something stable (main branch or release). Now it's hard sometimes to understand if it's your changes caused problems in CI or same problem exists in main

@artemgavrilov artemgavrilov changed the title Use commong CI triggers for all workflows [Proposal] Use commong CI triggers for all workflows Apr 8, 2024
@artemgavrilov artemgavrilov marked this pull request as ready for review April 9, 2024 16:39
@Naeem-Akhter
Copy link
Contributor

I would suggest to have this discussed in next full-force DS, as earlier we decided to have some workflows specific to PRs and others to PUSH.

Maybe we need to exclude the workflows against the Server Build too, as these are time consuming and potentially an unneeded overhead. And just adopt the server install via packages workflows only for both PR and PUSH.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (3d84610) to head (603c308).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   90.55%   84.56%   -6.00%     
==========================================
  Files           3        3              
  Lines        1271     1270       -1     
  Branches       35      196     +161     
==========================================
- Hits         1151     1074      -77     
  Misses         98       98              
- Partials       22       98      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov changed the title [Proposal] Use commong CI triggers for all workflows Tune CI triggers Apr 18, 2024
Copy link
Contributor

@Naeem-Akhter Naeem-Akhter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@artemgavrilov artemgavrilov merged commit 2ebd163 into main Apr 18, 2024
21 of 24 checks passed
@artemgavrilov artemgavrilov deleted the ci-triggers branch April 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants