-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune CI triggers #444
Tune CI triggers #444
Conversation
I would suggest to have this discussed in next full-force DS, as earlier we decided to have some workflows specific to PRs and others to PUSH. Maybe we need to exclude the workflows against the Server Build too, as these are time consuming and potentially an unneeded overhead. And just adopt the server install via packages workflows only for both PR and PUSH. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 90.55% 84.56% -6.00%
==========================================
Files 3 3
Lines 1271 1270 -1
Branches 35 196 +161
==========================================
- Hits 1151 1074 -77
Misses 98 98
- Partials 22 98 +76 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR sets same CI triggers for all workflows. It triggers all workflows on push in
main
branch, push of release tags and in Pull Requests. With that change we will be able to compare state of CI in feature PRs with something stable (main branch or release). Now it's hard sometimes to understand if it's your changes caused problems in CI or same problem exists inmain