PMM-2203 v0.5.0 #98
Merged
PMM-2203 v0.5.0 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 23.73% 23.74% +0.01%
==========================================
Files 39 39
Lines 2212 2152 -60
==========================================
- Hits 525 511 -14
+ Misses 1664 1615 -49
- Partials 23 26 +3
Continue to review full report at Codecov.
|
|
@rnovikovP ^^ |
golangci
reviewed
May 15, 2018
|
|
||
| // FIXME currently ignored | ||
| enabledGroupsFlag = flag.String("groups.enabled", "asserts,durability,background_flushing,connections,extra_info,global_lock,index_counters,network,op_counters,op_counters_repl,memory,locks,metrics", "Comma-separated list of groups to use, for more info see: docs.mongodb.org/manual/reference/command/serverStatus/") | ||
| // enabledGroupsFlag = flag.String("groups.enabled", "asserts,durability,background_flushing,connections,extra_info,global_lock,index_counters,network,op_counters,op_counters_repl,memory,locks,metrics", "Comma-separated list of groups to use, for more info see: docs.mongodb.org/manual/reference/command/serverStatus/") | ||
| enabledGroupsFlag = flag.String("groups.enabled", "", "Currently ignored") |
rnovikovP
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.5.0
Adds --test flag to verify connection with MongoDB and to quit.
Fixes URI logging in plain text including credentials when no session can be created.