Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Exporter not initiating connection to mongo when Unauthorized #1012

Open
wants to merge 1 commit into
base: release-0.41.3
Choose a base branch
from

Conversation

dudigit
Copy link

@dudigit dudigit commented Jan 19, 2025

PMM-XXXX (optional, if ticket reported)

  • Links to related pull requests (optional).

Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@dudigit dudigit requested a review from a team as a code owner January 19, 2025 16:21
@dudigit dudigit requested review from BupycHuk and JiriCtvrtka and removed request for a team January 19, 2025 16:21
@it-percona-cla
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Dudi Dolev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dudigit dudigit force-pushed the release-0.41.3-treat-collection-when-unauthorized branch from 04823da to 4943042 Compare January 22, 2025 11:51
@idoqo
Copy link
Contributor

idoqo commented Jan 24, 2025

Hi @dudigit please sign the GitHub CLA mentioned above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This completely changes how we build the docker image, is there any reason why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants