Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13327 - New MongoDB Router Summary dashboard #1626

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

sleto-it
Copy link
Contributor

@sleto-it sleto-it commented Aug 30, 2024

Still todo:

  • Change plugin from natel-discrete-panel to state-timeline.
  • Fix title of the first chart (and if needed check repeat for). It should be "Overview - name here" but the name is currently not shown.
    • We are currently using "title": "Overview - $service_name". But $service_name is not printed. If this is changed with "title": "Overview - $node_name" it works in my environment (does it cover all environments? if yes, good.)
    • Should we instead keep the title as it is, and use "repeat for service name"? right now it is using "repeat for node name". Note that if we repeat by service, the dashboard prints too many things. Either one or the other needs fix, I believe.
    • Fixed name with 3b2f2cd
  • Shall we remove "Disk space utilization" (mongodb_dbstats_fsUsedSize) ? No data is being reported in my test. I think this metric is only for conf / shard (non arbiters), and does not apply to mongoS
  • Shall we consider Blue color for disk IOPS and network traffic to be similar to replicaset summary dashboard?

@sleto-it
Copy link
Contributor Author

@YashSartanpara1 FYI

@sleto-it
Copy link
Contributor Author

sleto-it commented Sep 2, 2024

Hi @igroene when you have a moment, wanted to ask your opinion. See my question above:

Shall we remove "Disk space utilization" (mongodb_dbstats_fsUsedSize) ? No data is being reported in my test. I think this metric is only for conf / shard (non arbiters), and does not apply to mongoS

WDYT on this topic. Thanks

@igroene
Copy link
Member

igroene commented Sep 2, 2024

in my test env, mongodb_dbstats_fsUsedSize is populated even on mongos routers

@sleto-it
Copy link
Contributor Author

sleto-it commented Sep 2, 2024

@igroene thanks. Do you have this mongoS colocated with other nodes, perhaps this is the reason why you see data? or are you using the terraform script? from a teoretical point of view, which data should we measure for mongoS? for arbiters (in the replica set summary dashboard) I see the same "no data".

Which MongoDB version are you using? I am on 6.0.16

Thanks!

@igroene
Copy link
Member

igroene commented Sep 2, 2024

Hey Santo, this is using the terraform stuff so mongos router is on dedicated machines. For arbiters it makes sense to have no data, as dbstats cannot be run on them but mongos should show you data. Probably from mongos perspective the disk space is not that important so let's remove for now it if it's blocking progress. We can always go to the Node Summary on OS folder to check disk space

@sleto-it
Copy link
Contributor Author

sleto-it commented Sep 2, 2024

thanks for this clarification. I vote it to keep it as it works for you.

@YashSartanpara1 YashSartanpara1 merged commit 6d3e218 into percona:main Sep 4, 2024
5 of 6 checks passed
YashSartanpara1 pushed a commit that referenced this pull request Sep 4, 2024
* New Router Summary dashboard - v1

* name

* datasource cleanup

* $$hashKey cleanup

* warning message

* fix name in the chart

* yash fixes and improvements

* adds experimental tag
YashSartanpara1 added a commit that referenced this pull request Sep 4, 2024
* New Router Summary dashboard - v1

* name

* datasource cleanup

* $$hashKey cleanup

* warning message

* fix name in the chart

* yash fixes and improvements

* adds experimental tag

Co-authored-by: Santo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants