Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12070 Add Table plugin - db cluster summary #1511

Merged
merged 10 commits into from
Jul 31, 2023

Conversation

YashSartanpara1
Copy link
Contributor

@YashSartanpara1 YashSartanpara1 commented Jun 13, 2023

PMM-12070 Change boomtable plugin to grafana table plugin for DB cluster summary dashboard

FB - Percona-Lab/pmm-submodules#3305 (comment)

Before:
dbcluster
dbcluster2

After:
dbcluster1
dbcluster3

@rnovikovP rnovikovP changed the title Pmm 12070 table plugin db cluster summary PMM-12070 table plugin db cluster summary Jun 13, 2023
@ademidoff
Copy link
Member

@YashSartanpara1 Could you provide a feature build please?

@YashSartanpara1
Copy link
Contributor Author

@rnovikovP rnovikovP removed their request for review June 13, 2023 10:43
@ademidoff
Copy link
Member

@YashSartanpara1 I've checked how well the panels render on the dashboard. It looks like we need to improve the configuration to make them look neat.

@YashSartanpara1
Copy link
Contributor Author

@YashSartanpara1 I've checked how well the panels render on the dashboard. It looks like we need to improve the configuration to make them look neat.

@atymchuk Which configuration changes do you suggest?

ademidoff
ademidoff previously approved these changes Jun 21, 2023
Copy link
Member

@ademidoff ademidoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YashSartanpara1 YashSartanpara1 changed the title PMM-12070 table plugin db cluster summary PMM-12070 Add Table plugin - db cluster summary Jun 26, 2023
matejkubinec
matejkubinec previously approved these changes Jul 27, 2023
@YashSartanpara1 YashSartanpara1 merged commit 56bb2ef into main Jul 31, 2023
5 of 6 checks passed
@YashSartanpara1 YashSartanpara1 deleted the PMM-12070-table-plugin-db-cluster-summary branch July 31, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants