Merge pull request #9 from perawallet/fix/check-arbitrary-data

Check arbitrary data is signed correctly
perawallet · Oct 3, 2023 · d678a04 · d678a04
2 parents c8183e7 + eac7bb5
commit d678a04
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 11 deletions.
diff --git a/src/core/home/Home.tsx b/src/core/home/Home.tsx
@@ -205,7 +205,8 @@ function Home() {
 
       setAccountAddress(newAccounts[0]);
     } catch (e) {
-      console.log(e)
+      console.log(e);
+      handleSetLog(`${e}`);
     }
   }
 

diff --git a/src/core/home/sign-txn/SignTxn.tsx b/src/core/home/sign-txn/SignTxn.tsx
@@ -2,6 +2,7 @@ import {useState} from "react";
 import {Button, List, ListItem} from "@hipo/react-ui-toolkit";
 import {PeraWalletConnect} from "@perawallet/connect";
 import {SignerTransaction} from "@perawallet/connect/dist/util/model/peraWalletModels";
+import algosdk from "algosdk";
 
 import {mainnetScenarios, Scenario, scenarios} from "./util/signTxnUtils";
 import {ChainType, clientForChain} from "../../utils/algod/algod";
@@ -90,23 +91,35 @@ function SignTxn({
 
   async function signArbitraryData() {
     try {
+      const unsignedData = [
+        {
+          data: new Uint8Array(Buffer.from(`timestamp//${Date.now()}`)),
+          message: "Timestamp confirmation"
+        },
+        {
+          data: new Uint8Array(Buffer.from(`agent//${navigator.userAgent}`)),
+          message: "User agent confirmation"
+        }
+      ];
       const signedData: Uint8Array[] = await peraWallet.signData(
-        [
-          {
-            data: new Uint8Array(Buffer.from(`timestamp//${Date.now()}`)),
-            message: "Timestamp confirmation"
-          },
-          {
-            data: new Uint8Array(Buffer.from(`agent//${navigator.userAgent}`)),
-            message: "User agent confirmation"
-          }
-        ],
+        unsignedData,
         accountAddress
       );
 
+      unsignedData.forEach((data, index) => {
+        const isVerified = algosdk.verifyBytes(data.data, signedData[index], accountAddress)
+
+        console.log({data, signedData: signedData[index], isVerified});
+
+        if (!isVerified) {
+          handleSetLog(`Arbitrary data did not match with signed data!`);
+        }
+      });
+
       console.log({signedData});
       handleSetLog("Data signed successfully");
     } catch (error) {
+      console.log(error)
       handleSetLog(`${error}`);
     }
   }