Fixes Price Not Being Shown Correctly On Front End #168
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an item would be classified as trash it's price would be shown wrong on the front end. This is because it would ONLY multiply the items price by the trash rate. In the back end the trash multiplier is added on TOP of the item type rate. This would lead to the user getting a 'not enough value' error on the front end because the items price would be higher on the backend than it was shown to the user on the front end.
|
Sorry, have been busy over the holidays, will look into your PR and merge once I have looked over it, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an item would be classified as trash it's price would be shown wrong on the front end. This is because it would ONLY multiply the items price by the trash rate. In the back end the trash multiplier is added on TOP of the item type rate. This would lead to the user getting a 'not enough value' error on the front end because the items price would be higher on the backend than it was shown to the user on the front end.