Skip to content

Commit

Permalink
Don't reset state when changing from one selection to another in the …
Browse files Browse the repository at this point in the history
…editor

This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.

This fixes ppy#30839 and also the same
issue happening for the new combo toggle.

Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
  • Loading branch information
peppy committed Nov 26, 2024
1 parent 2859599 commit 86b294e
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,9 @@ private void createStateBindables()

private void resetTernaryStates()
{
if (SelectedItems.Count > 0)
return;

SelectionNewComboState.Value = TernaryState.False;
AutoSelectionBankEnabled.Value = true;
SelectionAdditionBanksEnabled.Value = true;
Expand Down

0 comments on commit 86b294e

Please sign in to comment.