Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POC for comparing datapack value vs datim #96

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

flopez-bao
Copy link
Contributor

@flopez-bao flopez-bao commented Sep 29, 2023

  • Add POC for comparing datapack value vs datim

Summary of Proposed Changes

  • Add a tab to comparison download sheet comparing datim vs datapack value
    • join d$memo$datim$analytics and d$data$analytics to compare datim values vs datapack values

Related Issues

Reviewer:

  • Tests added/updated & passing.
  • Clean linting.
  • Related issue ticket in Jira/GitHub.
  • Documentation added/updated.
  • Code conforms to style guidelines.
  • Well commented.
  • Updates reflected in NEWS.md.
  • Build check passes.

- Add POC for comparing datapack value vs datim
attempt merge to d$data$analytics
@flopez-bao
Copy link
Contributor Author

flopez-bao commented Oct 5, 2023

hey @jason-p-pickering , set up the code in the latest commit to attempt the full join we had discussed last week and after playing with the columns noted that when pulling from just a datapack I ended up with differing values for mechanism code which got in the way of the join.
Screen Shot 2023-10-05 at 3 50 27 PM

@jacksonsj mentioned a comparison would likely occur from a psnuxim tool, so I switched to loading a psnuxim tool OR both a datapack AND psnuxim tool. In both cases I unfortunately get a zero row comparison table:

Screen Shot 2023-10-05 at 4 02 35 PM

If I turn off https://github.com/pepfar-datim/datapackr-app/blob/master/server.R#L956 then I am able to get a comparison (whether accurate yet is to be seen):

Screen Shot 2023-10-05 at 4 21 38 PM

I tested with COP23 Indonesia and Botswana datapacks and psnuxim tools.

Is it expected behavior for the initial comparison_table object to be empty in the case of the upload of a psnuxim table?
And if so is it advisable to alter lines 956 to conditionally allow the workbook to be built for this use case?

Copy link
Contributor

@jason-p-pickering jason-p-pickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all commented code.

-removed hashed code
@flopez-bao
Copy link
Contributor Author

removed commented code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants