Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to enable pnpm link #1909

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Script to enable pnpm link #1909

merged 2 commits into from
Nov 18, 2024

Conversation

JasonMHasperhoven
Copy link
Contributor

@JasonMHasperhoven JasonMHasperhoven commented Nov 15, 2024

Currently pnpm linking does not work because the exports inside the package.json files of the packages refer to the src files:

"exports": {
    ".": "./src/index.ts",
    "./*": "./src/*.ts"
  },

This script can temporarily set the exports to the value of the publishConfig.exports, so that the exports will point to the dist folder.

It would work like this:

// inside penumbra-zone/web
node scripts/link-externally.js enable
cd packages/ui && dev:pack

// inside dex-explorer
pnpm link ../penumbra-zone/web/packages/ui

// to revert:
node scripts/link-externally.js disable

PS: Possible improvement would be to directly build a monorepo's package within the dex-explorer as part of the build pipeline.

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: e415f56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JasonMHasperhoven JasonMHasperhoven requested a review from a team November 15, 2024 16:48
Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution for this problem!

@vacekj
Copy link
Member

vacekj commented Nov 17, 2024

Nice, lgtm.

@grod220
Copy link
Collaborator

grod220 commented Nov 18, 2024

Would be helpful to get a demo of this local workflow in an upcoming sync

@JasonMHasperhoven JasonMHasperhoven merged commit b5cbea9 into main Nov 18, 2024
6 checks passed
@JasonMHasperhoven JasonMHasperhoven deleted the pnpm-link branch November 18, 2024 11:59
@JasonMHasperhoven
Copy link
Contributor Author

Would be helpful to get a demo of this local workflow in an upcoming sync

Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants