Pindexer auction #4870
Closed
Pindexer auction #4870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
This is a useful helper for indexing, and can also simplify the component code in the future
cronokirby
force-pushed
the
pindexer-auction
branch
from
96696c4
to
ebfed00
Compare
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
7 tasks
|
Closing in light of #4883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This adds an auction indexing component to pindexer.
Also, I added a utility function to the auction component to get the initial state of an auction from its description; this is useful so that the indexer always has some state of an auction.
I did not make the consensus code actually use this new function, but a subsequent refactor PR to use it would be nice to avoid code duplication, but in the interest of not adding new review burden, this PR does not do that.
Instead, reviewers, please check that I only moved code around, and that I only made more things visible in the crate.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: