build: use dev runtime for container image #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a temporary measure, uses the `pnpm run dev` environment inside the container image. This is an anti-pattern. We *should* be using the "standalone" output of nextjs and running that directly via `node`, but doing so does not permit runtime configuration of the chain-id, used for loading assets, which is must-have for the built image. Sprinkles in a few `justfile` additions to make testing locally a bit more straightforward, as we'll surely be exercising these config paths again in the near future. Refs #73.
|
Here we should revert to using the build command, but we should be able to provide different envs to the docker container and create multiple images, each for a different environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a temporary measure, uses the
pnpm run devenvironment inside the container image. This is an anti-pattern. We should be using the "standalone" output of nextjs and running that directly vianode, but doing so does not permit runtime configuration of the chain-id, used for loading assets, which is must-have for the built image.Sprinkles in a few
justfileadditions to make testing locally a bit more straightforward, as we'll surely be exercising these config paths again in the near future.Refs #73.