[BACKLOG-11838] Data Service AVG() aggregates are rounded down #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For TYPE_INTEGER fields, the avg calculation will truncate any decimals. Most databases will implicitly convert to double in such cases. This change alters the type of integer fields used in an avg aggregation to TYPE_NUMBER prior to the in-memory group by. http://jira.pentaho.com/browse/BACKLOG-11838 (cherry picked from commit 5291f66)
Build Completed✅ This pull request has passed all validations. Build Commandsmvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml siteCleanup Commandsmvn -B -f pom.xml build-helper:remove-project-artifactChanged files src/main/java/org/pentaho/di/trans/dataservice/SqlTransGenerator.java
src/test/java/org/pentaho/di/trans/dataservice/SqlTransGeneratorTest.javaUnit test coverage changeThese statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation. org.pentaho.di.trans.dataservice.SqlTransGenerator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TYPE_INTEGER fields, the avg calculation will truncate any
decimals. Most databases will implicitly convert to double in such
cases. This change alters the type of integer fields used in an
avg aggregation to TYPE_NUMBER prior to the in-memory group by.
http://jira.pentaho.com/browse/BACKLOG-11838
(cherry picked from commit 5291f66)
@kcruzada