Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lg/breaking changes #25

Merged
merged 14 commits into from
Nov 12, 2024
Merged

Lg/breaking changes #25

merged 14 commits into from
Nov 12, 2024

Conversation

lauragilgz
Copy link
Contributor

Add more granularity to the Operation details, and separate what was being returned in label in the corresponding free_label, structured_label, structured_label_2 or the original label.

Operation details can be accessed in operation.details, in case of needing to access a specific attribute it can be accessed with an instance variable like operation.details.strcutured_label.

README.md Outdated Show resolved Hide resolved
cfonb.gemspec Outdated Show resolved Hide resolved
lib/cfonb/operation.rb Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/cfonb/operation_details.rb Outdated Show resolved Hide resolved
lib/cfonb/operation_details/rcn.rb Outdated Show resolved Hide resolved
lib/cfonb/operation_details/rcn.rb Outdated Show resolved Hide resolved
lib/cfonb/operation_details/ref.rb Outdated Show resolved Hide resolved
lib/cfonb/operation_details/ref.rb Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lauragilgz lauragilgz requested review from RDeckard and removed request for jlebray November 7, 2024 16:50
Copy link
Collaborator

@RDeckard RDeckard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

lib/cfonb/operation.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@frantisekrokusek frantisekrokusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment, otherwise it's good

README.md Outdated Show resolved Hide resolved
@lauragilgz lauragilgz merged commit b6fef0c into master Nov 12, 2024
1 check passed
@lauragilgz lauragilgz self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants