Increase major #23
Closed
Increase major #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauragilgz
requested review from
frantisekrokusek,
jlebray and
NathanBerthier
as code owners
frantisekrokusek
requested changes
Oct 29, 2024
lib/cfonb/operation_detail/lc2.rb
Outdated
Comment on lines
9
to
13
| operation.unstructured_label_2 = if operation.unstructured_label_2.nil? | ||
| line.detail.strip.to_s | ||
| else | ||
| "#{operation.unstructured_label_2}\n#{line.detail.strip}" | ||
| end |
There was a problem hiding this comment.
I think there can only be one line of this
Suggested change
| operation.unstructured_label_2 = if operation.unstructured_label_2.nil? | |
| line.detail.strip.to_s | |
| else | |
| "#{operation.unstructured_label_2}\n#{line.detail.strip}" | |
| end | |
| operation.unstructured_label_2 = line.detail.strip |
lib/cfonb/operation_detail/lcc.rb
Outdated
Comment on lines
9
to
13
| operation.unstructured_label = if operation.unstructured_label.nil? | ||
| line.detail.strip.to_s | ||
| else | ||
| "#{operation.unstructured_label}\n#{line.detail.strip}" | ||
| end |
There was a problem hiding this comment.
same here
Suggested change
| operation.unstructured_label = if operation.unstructured_label.nil? | |
| line.detail.strip.to_s | |
| else | |
| "#{operation.unstructured_label}\n#{line.detail.strip}" | |
| end | |
| operation.unstructured_label = line.detail.strip |
lib/cfonb/operation_detail/lcs.rb
Outdated
Comment on lines
11
to
15
| operation.structured_label = if operation.structured_label.nil? | ||
| formatted_label.to_s | ||
| else | ||
| "#{operation.structured_label}\n#{formatted_label}" | ||
| end |
There was a problem hiding this comment.
same here
Suggested change
| operation.structured_label = if operation.structured_label.nil? | |
| formatted_label.to_s | |
| else | |
| "#{operation.structured_label}\n#{formatted_label}" | |
| end | |
| operation.structured_label = formatted_label |
lib/cfonb/operation_detail/lib.rb
Outdated
Comment on lines
9
to
13
| operation.free_label = if operation.free_label.nil? | ||
| line.detail.strip.to_s | ||
| else | ||
| "#{operation.free_label}\n#{line.detail.strip}" | ||
| end |
There was a problem hiding this comment.
This doesn't work ?
Suggested change
| operation.free_label = if operation.free_label.nil? | |
| line.detail.strip.to_s | |
| else | |
| "#{operation.free_label}\n#{line.detail.strip}" | |
| end | |
| operation.free_label += if operation.free_label.nil? | |
| line.detail.strip | |
| else | |
| "\n#{line.detail.strip}" | |
| end |
There was a problem hiding this comment.
I modified it since free_label can be nil because it is not part of the base attributes, and then we cannot concatenate the string 😢
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…il_code value setting
…' into Increase-major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more granularity to the Operation details, and separate what was being returned in label in the corresponding free_label, structured_label, structured_label_2 or the original label