Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ingress Annotations to Fix Force HTTPS #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joyliu-q
Copy link
Contributor

@joyliu-q joyliu-q commented Sep 15, 2023

  • TODO: talk to Rohan about if this is correct
  • TODO: add new version in package.json

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f66f263) 97.35% compared to head (ef9bb59) 97.35%.

❗ Current head ef9bb59 differs from pull request most recent head 5cc1f94. Consider uploading reports for the commit 5cc1f94 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          16       16           
  Lines         265      265           
  Branches       73       73           
=======================================
  Hits          258      258           
  Misses          5        5           
  Partials        2        2           
Flag Coverage Δ
kittyhawk 97.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cdk/kittyhawk/src/ingress.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant