Fix Warnings, raise meson warning level #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bith3ad
reviewed
Jul 19, 2024
bith3ad
force-pushed
the
topic/fix-warnings
branch
from
59ba9c4 to
c30b0ce
Compare
The include <stdarg.h> is not used anywhere, remove it. Signed-off-by: Rouven Czerwinski <[email protected]>
The directory and base name are created with a const qualifier and are not modified in the draw function, pass them as const. Signed-off-by: Rouven Czerwinski <[email protected]>
Emantor
force-pushed
the
topic/fix-warnings
branch
from
c30b0ce to
59a2e3f
Compare
|
I rebased to fix my author email & SoB. |
pH5
approved these changes
Jul 24, 2024
The sizeof operator will return a long unsigned int which raises a sign compare issue when compared to int. By making use of asprintf() we can reduce the length restrictions as well which is a nice side effect. Signed-off-by: Marco Felsch <[email protected]>
The crtc_id is used as crtc_id but also as indicator that the crtc_id is already in use. For this crtc_id was declared as int32. This cause a sign compare issue when compared to unsigned int. Introduce a local boolean to check if the crtc_id is already in use and declare the crtc_id as uint32_t to fix this. Signed-off-by: Marco Felsch <[email protected]>
In both cases the count of items the for loop is iterating over are integers, use integers for the iteration to avoid a sign compare warning. Signed-off-by: Rouven Czerwinski <[email protected]>
The ARRAY_SIZE macro returns an unsigned integer, use an unsigned int for the loop to avoid a sign compare warning. Signed-off-by: Rouven Czerwinski <[email protected]>
Signed-off-by: Rouven Czerwinski <[email protected]>
bith3ad
force-pushed
the
topic/fix-warnings
branch
from
59a2e3f to
91c4768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various warnings and raise the meson warning level to two.